Conversation
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Pull request overview
Adds an initial documentation entry point for the Community Toolkit Perl hosting integration, including nav placement and related data/assets in the frontend docs site.
Changes:
- Added a new Perl framework doc page and Perl icon asset.
- Added “Perl” to the Integrations sidebar under Frameworks & runtimes.
- Added the Perl package ID to the integrations name list and added new license title entries.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/frontend/src/data/thanks-license-titles.ts | Adds new license title entries for Perl-related assets (currently includes a TS syntax error). |
| src/frontend/src/data/aspire-integration-names.json | Adds CommunityToolkit.Aspire.Hosting.Perl to the integration package name list. |
| src/frontend/src/content/docs/integrations/frameworks/perl.mdx | Introduces a new Perl integration doc page (currently mostly placeholder content). |
| src/frontend/src/assets/icons/perl-096-1500.svg | Adds a Perl logo SVG used by the new doc page. |
| src/frontend/config/sidebar/integrations.topics.ts | Adds the Perl doc page to the integrations sidebar nav. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "CommunityToolkit.Aspire.Hosting.Ollama", | ||
| "CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector", | ||
| "CommunityToolkit.Aspire.Hosting.PapercutSmtp", | ||
| "CommunityToolkit.Aspire.Hosting.Perl", |
There was a problem hiding this comment.
CommunityToolkit.Aspire.Hosting.Perl is added to the integration name list, but there’s no corresponding entry in src/frontend/src/data/integration-docs.json mapping that package ID to /integrations/frameworks/perl/. Without that, the Integrations gallery won’t surface a docs link for this package.
| "CommunityToolkit.Aspire.Hosting.Perl", |
There was a problem hiding this comment.
I believe we need to wait until the CT 13.2 release? I believe I only have this package in preview at the moment after it merged into main of the CT.
Unsure how to proceed on this point.
…e harness first. Also changed some of the feedback from the PR.
…fixing the thanks-license-titles.ts
Omnideth
force-pushed
the
perl-documentation-addition
branch
from
f5cc9d5 to
9847934
Compare
The perl integration has been pulled into main of the Community Toolkit, but I believe the package is not yet available.
I wanted to go ahead and submit this to see what else I need to do to add documentation for it when it does go live and get published.